Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: add sanity check for startTS in 2pc (#9555) #9559

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@disksing
Copy link
Member

commented Mar 5, 2019

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

To avoid committing a transaction with MAX_UINT64 unexpectedly.
Sometimes (PointGet, Analyze) TiDB uses special startTS (MAX_UINT64) to initialize a transaction. This is dangerous because txn.Commit() may be called unexpectedly.

What is changed and how it works?

cherry-pick #9555

Check List

Tests

  • Unit test
store/tikv: add sanity check for startTS in 2pc (#9555)
* store/tikv: add sanity check for startTS in 2pc

Signed-off-by: disksing <i@disksing.com>
@shenli

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

LGTM

@shenli shenli added the status/LGT1 label Mar 5, 2019

@jackysp

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@jackysp

jackysp approved these changes Mar 5, 2019

Copy link
Member

left a comment

LGTM

@jackysp jackysp merged commit 899b7fc into pingcap:release-2.1 Mar 5, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.