Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain, store/tikv: enable etcd client auto sync (#9575) #9600

Merged
merged 3 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@disksing
Copy link
Member

disksing commented Mar 7, 2019

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

When all PD nodes are replaced by new PD nodes, etcd clients (used by DDL worker and safepoint syncer) in tidb will lost connection with PD cluster.

What is changed and how it works?

Enable etcd's AutoSync feature so it will automatically update member list.
cherry-pick #9575

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. start a cluster with 3 PDs, 1 TiKV, 1TiDB
  2. Join 3 more PDs then member delete original 3 PDs.
  3. Wait 100s and check if there are any 'safePoint out of sync' errors (TRUE for master, FALSE for auto-sync)
  4. Run some DDL and check if it succeds (FALSE for master, TRUE for auto-sync)

Note: No unit test case included, it will be more suitable to add a integration test in schrodinger later. This bug is kind urgent and the fix is straightforward so I guess we can merge it ahead.

Related changes

  • Need to be included in the release note

@disksing disksing requested review from zimulala and nolouch Mar 7, 2019

@jackysp

This comment has been minimized.

Copy link
Member

jackysp commented Mar 7, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@jackysp
Copy link
Member

jackysp left a comment

LGTM

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason merged commit af34714 into pingcap:release-2.1 Mar 7, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.