Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build:fix `git describe` in sometimes fatal. #9611

Merged
merged 2 commits into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@xiekeyi98
Copy link
Member

xiekeyi98 commented Mar 8, 2019

What problem does this PR solve?

Like the pic you see,
Sometimes the CI may have fatal. (https://travis-ci.org/pingcap/tidb/jobs/503157463)
image

What is changed and how it works?

Like the solution in StackOverflow: https://stackoverflow.com/questions/4916492/git-describe-fails-with-fatal-no-names-found-cannot-describe-anything.

Check List

Tests

  • No code
@winkyao
Copy link
Member

winkyao left a comment

LGTM

@xiekeyi98

This comment has been minimized.

Copy link
Member Author

xiekeyi98 commented Mar 8, 2019

/run-all-tests

@xiekeyi98

This comment has been minimized.

Copy link
Member Author

xiekeyi98 commented Mar 8, 2019

If we have tags, use git describe --tags --dirty --always is nothing different with git describe --tags --dirty(Only test manually).
If we do not have tags, use git describes --tags --dirty --always will show the last commit. (I think).

@xiekeyi98

This comment has been minimized.

Copy link
Member Author

xiekeyi98 commented Mar 8, 2019

/run-unit-test

@crazycs520
Copy link
Contributor

crazycs520 left a comment

LGTM

@xiekeyi98 xiekeyi98 merged commit b00c207 into pingcap:master Mar 8, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@xiekeyi98 xiekeyi98 deleted the xiekeyi98:adjustMakefil branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.