Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support window function cume_dist #9619

Merged
merged 6 commits into from Mar 11, 2019

Conversation

@lamxTyler
Copy link
Member

commented Mar 8, 2019

What problem does this PR solve?

Support window function cume_dist. Refer https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_cume-dist

For #9499

What is changed and how it works?

Implement the cume_dist under the aggfunc interface.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@lamxTyler lamxTyler added this to In progress in window function via automation Mar 8, 2019

@lamxTyler lamxTyler requested review from zz-jason, qw4990 and winoros Mar 8, 2019

@lamxTyler lamxTyler referenced this pull request Mar 8, 2019

Closed

support all window functions #9499

11 of 11 tasks complete
@codecov

This comment has been minimized.

Copy link

commented Mar 8, 2019

Codecov Report

Merging #9619 into master will decrease coverage by 0.0439%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             master      #9619       +/-   ##
===============================================
- Coverage   67.4239%   67.3799%   -0.044%     
===============================================
  Files           375        376        +1     
  Lines         79144      79160       +16     
===============================================
- Hits          53362      53338       -24     
- Misses        21006      21052       +46     
+ Partials       4776       4770        -6
Show resolved Hide resolved executor/aggfuncs/func_rank.go Outdated

zhouqiang-cl and others added some commits Mar 9, 2019

Update executor/aggfuncs/func_rank.go
Co-Authored-By: lamxTyler <lambdax.tyler@gmail.com>
@zz-jason
Copy link
Member

left a comment

LGTM

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

/run-all-tests

@qw4990

qw4990 approved these changes Mar 11, 2019

Copy link
Contributor

left a comment

LGTM

window function automation moved this from In progress to Reviewer approved Mar 11, 2019

@lamxTyler lamxTyler added status/LGT2 and removed status/LGT1 labels Mar 11, 2019

@lamxTyler lamxTyler merged commit f0aca29 into pingcap:master Mar 11, 2019

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

window function automation moved this from Reviewer approved to Done Mar 11, 2019

@lamxTyler lamxTyler deleted the lamxTyler:cume_dist branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.