Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix select denied message #9627

Merged
merged 6 commits into from Mar 11, 2019

Conversation

Projects
None yet
5 participants
@AndrewDi
Copy link
Contributor

AndrewDi commented Mar 10, 2019

What problem does this PR solve?

Fix issue #9191

What is changed and how it works?

Pass SELECT denied message to visitinfo.

Check List

Tests

  • Unit test
@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

AndrewDi commented Mar 10, 2019

@morgo PTAL

@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

AndrewDi commented Mar 10, 2019

/run-all-tests

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 10, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@22af193). Click here to learn what that means.
The diff coverage is 50%.

@@             Coverage Diff             @@
##             master      #9627   +/-   ##
===========================================
  Coverage          ?   67.4564%           
===========================================
  Files             ?        375           
  Lines             ?      79180           
  Branches          ?          0           
===========================================
  Hits              ?      53412           
  Misses            ?      20999           
  Partials          ?       4769
@morgo
Copy link
Member

morgo left a comment

LGTM

@morgo morgo added the status/LGT1 label Mar 10, 2019

@morgo

This comment has been minimized.

Copy link
Member

morgo commented Mar 10, 2019

/run-all-tests

@eurekaka

This comment has been minimized.

Copy link
Contributor

eurekaka commented Mar 11, 2019

/run-integration-common-test

@eurekaka
Copy link
Contributor

eurekaka left a comment

LGTM

@eurekaka eurekaka added status/LGT2 and removed status/LGT1 labels Mar 11, 2019

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Mar 11, 2019

/run-integration-common-test

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

zz-jason and others added some commits Mar 11, 2019

@ngaut ngaut merged commit 45c9458 into pingcap:master Mar 11, 2019

4 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job is running.
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@AndrewDi AndrewDi deleted the AndrewDi:fix_select_error branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.