Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add window function PERCENT_RANK #9671

Merged
merged 3 commits into from Mar 13, 2019

Conversation

@winoros
Copy link
Member

commented Mar 12, 2019

What problem does this PR solve?

Add window function support for PERCENT_RANK. Part of #9499

What is changed and how it works?

Following the calculation formula percent_rank = (rank - 1) / (rows_in_set - 1)

Check List

Tests

  • Unit test

@winoros winoros requested review from lamxTyler, qw4990 and zz-jason Mar 12, 2019

@lamxTyler lamxTyler added this to In progress in window function via automation Mar 12, 2019

@lamxTyler lamxTyler referenced this pull request Mar 12, 2019

Closed

support all window functions #9499

11 of 11 tasks complete
@lamxTyler
Copy link
Member

left a comment

LGTM

@codecov

This comment has been minimized.

Copy link

commented Mar 12, 2019

Codecov Report

Merging #9671 into master will decrease coverage by 0.0197%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             master      #9671        +/-   ##
================================================
- Coverage   67.4153%   67.3955%   -0.0198%     
================================================
  Files           376        377         +1     
  Lines         79252      79345        +93     
================================================
+ Hits          53428      53475        +47     
- Misses        21052      21099        +47     
+ Partials       4772       4771         -1
address comment
Co-Authored-By: winoros <winoros@gmail.com>
@qw4990
Copy link
Contributor

left a comment

LGTM

@zz-jason
Copy link
Member

left a comment

LGTM

window function automation moved this from In progress to Reviewer approved Mar 13, 2019

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Mar 13, 2019

@zz-jason

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

/run-all-tests

@winoros winoros merged commit f5a4dd9 into pingcap:master Mar 13, 2019

16 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 67.3955% (-0.0198%) compared to aef66b2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

window function automation moved this from Reviewer approved to Done Mar 13, 2019

@winoros winoros deleted the winoros:window-percent-rank branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.