Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support window function lead and lag #9672

Merged
merged 6 commits into from Mar 14, 2019

Conversation

@lamxTyler
Copy link
Member

commented Mar 12, 2019

What problem does this PR solve?

Support window function lead and lag.
Refer https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lead and https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lag

For #9499

What is changed and how it works?

Implement the lead and lag under the aggfunc interface.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@lamxTyler lamxTyler added this to In progress in window function via automation Mar 12, 2019

@lamxTyler lamxTyler requested review from zz-jason, qw4990 and winoros Mar 12, 2019

@lamxTyler lamxTyler referenced this pull request Mar 12, 2019

Closed

support all window functions #9499

11 of 11 tasks complete
@codecov

This comment has been minimized.

Copy link

commented Mar 12, 2019

Codecov Report

Merging #9672 into master will increase coverage by 0.0448%.
The diff coverage is 4.054%.

@@               Coverage Diff                @@
##             master      #9672        +/-   ##
================================================
+ Coverage   67.3717%   67.4166%   +0.0448%     
================================================
  Files           377        378         +1     
  Lines         79465      79872       +407     
================================================
+ Hits          53537      53847       +310     
- Misses        21140      21222        +82     
- Partials       4788       4803        +15
@qw4990
Copy link
Contributor

left a comment

LGTM

@zz-jason
Copy link
Member

left a comment

LGTM

window function automation moved this from In progress to Reviewer approved Mar 14, 2019

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

/run-all-tests

@lamxTyler lamxTyler merged commit 4422a23 into pingcap:master Mar 14, 2019

4 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job is running.
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

window function automation moved this from Reviewer approved to Done Mar 14, 2019

@lamxTyler lamxTyler deleted the lamxTyler:leadlag branch Mar 14, 2019

xiekeyi98 added a commit to xiekeyi98/tidb that referenced this pull request Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.