Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add window function NTILE #9682

Merged
merged 7 commits into from Mar 15, 2019

Conversation

@winoros
Copy link
Member

commented Mar 12, 2019

What problem does this PR solve?

Implement window function NTILE. It divides the rows into n groups, and returns the group number a row belongs to.

Part of #9499

What is changed and how it works?

Implement its execution logic

Check List

Tests

  • Unit test

Related changes

  • Need to update the documentation

@winoros winoros requested review from zz-jason, qw4990 and lamxTyler Mar 12, 2019

@lamxTyler lamxTyler referenced this pull request Mar 12, 2019

Closed

support all window functions #9499

11 of 11 tasks complete

winoros added some commits Mar 13, 2019

@lamxTyler lamxTyler added this to In progress in window function via automation Mar 13, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 13, 2019

Codecov Report

Merging #9682 into master will decrease coverage by 0.0245%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             master      #9682        +/-   ##
================================================
- Coverage   67.2243%   67.1998%   -0.0246%     
================================================
  Files           380        381         +1     
  Lines         79788      79835        +47     
================================================
+ Hits          53637      53649        +12     
- Misses        21361      21404        +43     
+ Partials       4790       4782         -8

type partialResult4Ntile struct {
curIdx uint64
divisor uint64

This comment has been minimized.

Copy link
@lamxTyler

lamxTyler Mar 13, 2019

Member

Is it needed? Can we just use the n in ntile?

winoros added some commits Mar 15, 2019

@winoros winoros requested a review from lamxTyler Mar 15, 2019

@lamxTyler
Copy link
Member

left a comment

LGTM

window function automation moved this from In progress to Reviewer approved Mar 15, 2019

@zz-jason
Copy link
Member

left a comment

LGTM

@winoros winoros merged commit 3a48d9c into pingcap:master Mar 15, 2019

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

window function automation moved this from Reviewer approved to Done Mar 15, 2019

@winoros winoros deleted the winoros:window-ntile branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.