Skip to content

expression,types: improve str_to_date builtin function compatibility (9617)#9817

Merged
ngaut merged 2 commits into
pingcap:release-2.1from
tiancaiamao:cherry-2.1
Mar 20, 2019
Merged

expression,types: improve str_to_date builtin function compatibility (9617)#9817
ngaut merged 2 commits into
pingcap:release-2.1from
tiancaiamao:cherry-2.1

Conversation

@tiancaiamao

Copy link
Copy Markdown
Contributor

Cherry pick from #9617

PTAL @zz-jason @lysu

@zz-jason zz-jason left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 20, 2019
@zz-jason

Copy link
Copy Markdown
Member

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@eurekaka eurekaka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 20, 2019
@ngaut ngaut merged commit 2129872 into pingcap:release-2.1 Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants