Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binlog: revert commit for variable `tidb_log_bin` && add send binlog strategy config #9864

Merged
merged 6 commits into from Mar 24, 2019

Conversation

@WangXiangUSTC
Copy link
Member

commented Mar 22, 2019

What problem does this PR solve?

  1. we decide don't support change binlog online, tidb_log_bin is useless now
  2. can change send binlog's strategy

What is changed and how it works?

  1. revert two commit
  2. add new config binlog.strategy

Check List

Tests

  • Manual test (set binlog.strategy in config file, and run test)

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note
@codecov

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #9864 into master will decrease coverage by 0.0148%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #9864        +/-   ##
================================================
- Coverage   67.3512%   67.3363%   -0.0149%     
================================================
  Files           383        383                
  Lines         80444      80435         -9     
================================================
- Hits          54180      54162        -18     
- Misses        21421      21425         +4     
- Partials       4843       4848         +5
@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

/run-all-tests

1 similar comment
@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

/run-all-tests

@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

/run-unit-test

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

LGTM

@jackysp
Copy link
Member

left a comment

LGTM

jackysp and others added some commits Mar 24, 2019

@WangXiangUSTC WangXiangUSTC merged commit d5f0d2b into pingcap:master Mar 24, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 5ed3553...7adbd8e
Details
codecov/project 67.3363% (-0.0149%) compared to 5ed3553
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/code_coverage Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@WangXiangUSTC WangXiangUSTC deleted the WangXiangUSTC:xiang/binlog_stragy branch Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.