Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: enable hash partition and range columns partition by default #9936

Merged
merged 5 commits into from May 8, 2019

Conversation

Projects
None yet
3 participants
@tiancaiamao
Copy link
Contributor

commented Mar 28, 2019

What problem does this PR solve?

Enable a feature

What is changed and how it works?

Check List

Tests

  • No code
@codecov

This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #9936 into master will increase coverage by 0.0017%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master      #9936        +/-   ##
================================================
+ Coverage   77.3752%   77.3769%   +0.0017%     
================================================
  Files           412        412                
  Lines         85698      85665        -33     
================================================
- Hits          66309      66285        -24     
+ Misses        14353      14350         -3     
+ Partials       5036       5030         -6
@jackysp
Copy link
Member

left a comment

LGTM

@jackysp jackysp requested a review from lysu May 5, 2019

@lysu

lysu approved these changes May 5, 2019

Copy link
Member

left a comment

LGTM

@lysu
Copy link
Member

left a comment

DNM

@tiancaiamao tiancaiamao removed the status/DNM label May 8, 2019

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

/run-all-tests

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Now that #10273 has been merged, I'll remove the DNM tag

PTAL @jackysp @lysu

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

/run-idc-jenkins-ci-tidb/common-test

@tiancaiamao tiancaiamao requested a review from lysu May 8, 2019

@lysu

lysu approved these changes May 8, 2019

@tiancaiamao tiancaiamao merged commit e56a14b into pingcap:master May 8, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 77.3769% (+0.0017%) compared to 67583f9
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:enable-hash-partition branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.