This repository has been archived by the owner. It is now read-only.

fix update leader #105

Merged
merged 19 commits into from Sep 21, 2017

Conversation

Projects
None yet
2 participants
@zhexuany
Member

zhexuany commented Sep 18, 2017

After this, logic of updating region leader should be correct.


This change is Reviewable

@ilovesoup

LGTM for now. I will merge and test on another branch with some other change together.

@ilovesoup

This comment has been minimized.

Show comment
Hide comment
@ilovesoup

ilovesoup Sep 18, 2017

Contributor

Also deleted channel close since underlying channel would be kept alive unless non-idle by GRPC itself (idle timeout added).
Recent tests on single machine vs multiple kv shows the concurrent channel racing issue when close channel due to problem discussed here
https://groups.google.com/forum/#!topic/grpc-io/6e0GFRSWit8
It seems channel shutdown is not graceful as said in grpc code comment.
So we simply remove it.

Contributor

ilovesoup commented Sep 18, 2017

Also deleted channel close since underlying channel would be kept alive unless non-idle by GRPC itself (idle timeout added).
Recent tests on single machine vs multiple kv shows the concurrent channel racing issue when close channel due to problem discussed here
https://groups.google.com/forum/#!topic/grpc-io/6e0GFRSWit8
It seems channel shutdown is not graceful as said in grpc code comment.
So we simply remove it.

ilovesoup and others added some commits Sep 19, 2017

Merge branch 'fix-update-leader-logic' of github.com:pingcap/tikv-cli…
…ent-lib-java into fix-update-leader-logic

@ilovesoup ilovesoup merged commit 0dfdde7 into master Sep 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zhexuany zhexuany deleted the fix-update-leader-logic branch Sep 21, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.