bin: handle TERM/INT signal #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| break; | ||
| } | ||
| // TODO: handle more signal | ||
| _ => debug!("ignore signal: {}", sig), |
BusyJay
changed the title
BusyJay
changed the title
| fn handle_signal(ch: SendCh<Msg>) { | ||
| use signal::trap::Trap; | ||
| use nix::sys::signal::{SIGTERM, SIGINT}; | ||
| let trap = Trap::trap(&[SIGTERM, SIGINT]); |
There was a problem hiding this comment.
it will block until receiving a signal?
There was a problem hiding this comment.
No, the for loop below will block.
There was a problem hiding this comment.
Couldn't find any doc or example how trap should be used.
Will it rerun this piece of signal catching code if the specified signal happens? Like a callback.
There was a problem hiding this comment.
Docs: https://tailhook.github.io/signal/signal/trap/index.html
Examples: https://github.com/tailhook/signal/tree/master/examples
It use sigwait internally, see also http://man7.org/linux/man-pages/man3/sigwait.3.html
|
LGTM |
|
PTAL |
|
LGTM |
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
Oct 30, 2023
…1058) Signed-off-by: Ping Yu <yuping@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1053