Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: aggr null for first #1339

Merged
merged 1 commit into from Nov 22, 2016
Merged

copr: aggr null for first #1339

merged 1 commit into from Nov 22, 2016

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Nov 22, 2016

@coocood
Copy link
Contributor

coocood commented Nov 22, 2016

LGTM

@BusyJay
Copy link
Member Author

BusyJay commented Nov 22, 2016

@siddontang PTAL

@siddontang
Copy link
Contributor

Seem not the same with the TiDB PR.

@BusyJay
Copy link
Member Author

BusyJay commented Nov 22, 2016

TiDB uses a flag to indicate if the result is set. But we use an Option already, no need to add an additional flag.

@siddontang
Copy link
Contributor

LGTM

@BusyJay BusyJay merged commit 25e3666 into master Nov 22, 2016
@BusyJay BusyJay deleted the busyjay/dont-skip-null branch November 22, 2016 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants