Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft: port promotable checking for MsgTimeoutNow #1473

Merged
merged 2 commits into from Jan 9, 2017
Merged

raft: port promotable checking for MsgTimeoutNow #1473

merged 2 commits into from Jan 9, 2017

Conversation

hhkbp2
Copy link
Contributor

@hhkbp2 hhkbp2 commented Jan 7, 2017

Hi,

This PR port the promotable checking for MsgTimeoutNow from etcd/raft.
It substitutes #1356

@hhkbp2
Copy link
Contributor Author

hhkbp2 commented Jan 7, 2017

PTAL @siddontang @BusyJay

@siddontang
Copy link
Contributor

LGTM

@ngaut
Copy link
Member

ngaut commented Jan 8, 2017

Please fix CI

@hhkbp2 hhkbp2 mentioned this pull request Jan 9, 2017
Merged
@hhkbp2
Copy link
Contributor Author

hhkbp2 commented Jan 9, 2017

PTAL @ngaut @BusyJay
The CI build failure before is caused by #1462, it's OK to merge this PR.

@BusyJay
Copy link
Member

BusyJay commented Jan 9, 2017

LGTM

@ngaut ngaut merged commit fae3c2f into master Jan 9, 2017
@ngaut ngaut deleted the hhkbp2/port-promotable-checking-for-MsgTimeoutNow branch January 9, 2017 05:06
@sre-bot sre-bot added the contribution Type: PR - From contributors label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay BusyJay approved these changes

Assignees
No one assigned
Labels
contribution Type: PR - From contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hhkbp2 @siddontang @ngaut @BusyJay @sre-bot