flow control using total writing bytes #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
zhangjinpeng87
requested review from
siddontang
and removed request for
disksing
siddontang
reviewed
Oct 24, 2017
etc/config-template.toml
Outdated
| # scheduler-too-busy-threshold = 10000 | ||
| # When the pending write bytes exceeds this threshold, | ||
| # the "scheduler too busy" error is displayed. | ||
| # scheduler_pending_write_threshold = "10MB" |
There was a problem hiding this comment.
s/scheduler_pending_write_threshold/scheduler-pending-write-threshold/
|
LGTM |
src/storage/config.rs
Outdated
| // According to "Little's law", assuming you can write 100MB per | ||
| // second, and it takes about 100ms to process the write requests | ||
| // on average, hence using the 10MB as the default value here. | ||
| const DEFAULT_SCHED_PENDING_WRITE_MB: u64 = 10; |
There was a problem hiding this comment.
I think we can tolerate a larger latency (e.g. 1s), so maybe 100MB is more proper?
|
/run-all-test |
1 similar comment
|
/run-all-test |
zhangjinpeng87
added a commit
that referenced
this pull request
Oct 26, 2017
zhangjinpeng87
added a commit
that referenced
this pull request
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.