New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flow control using total writing bytes #2408
Conversation
/run-all-tests |
etc/config-template.toml
Outdated
# scheduler-too-busy-threshold = 10000 | ||
# When the pending write bytes exceeds this threshold, | ||
# the "scheduler too busy" error is displayed. | ||
# scheduler_pending_write_threshold = "10MB" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/scheduler_pending_write_threshold/scheduler-pending-write-threshold/
LGTM |
src/storage/config.rs
Outdated
// According to "Little's law", assuming you can write 100MB per | ||
// second, and it takes about 100ms to process the write requests | ||
// on average, hence using the 10MB as the default value here. | ||
const DEFAULT_SCHED_PENDING_WRITE_MB: u64 = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can tolerate a larger latency (e.g. 1s), so maybe 100MB is more proper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-test |
1 similar comment
/run-all-test |
No description provided.