Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable set, enum and bit pushed down #1242

Merged
merged 3 commits into from Nov 26, 2019

Conversation

@zhexuany
Copy link
Member

zhexuany commented Nov 25, 2019

What problem does this PR solve?

This PR disables set, enum and bit pushed down.

The reason we do that is because TiKV does not support these type's pushdown.

This PR closes #1244

@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 25, 2019

/run-all-tests

@marsishandsome

This comment has been minimized.

Copy link
Collaborator

marsishandsome commented Nov 25, 2019

/run-all-tests

@marsishandsome

This comment has been minimized.

Copy link
Collaborator

marsishandsome commented Nov 25, 2019

please add why disables set, enum and bit pushed down? in PR description

@zhexuany zhexuany force-pushed the zhexuany:disable_set_and_enum_push_down branch 2 times, most recently from 0871a3e to b47eb28 Nov 25, 2019
@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 25, 2019

/run-all-tests

case attr: AttributeReference if nameTypeMap.contains(attr.name) =>
val head = nameTypeMap.get(attr.name).head
return !head.isInstanceOf[BitType]
return nameTypeMap.get(attr.name).head.isPushDownSupported

This comment has been minimized.

Copy link
@marsishandsome

marsishandsome Nov 25, 2019

Collaborator

two returns?

This comment has been minimized.

Copy link
@zhexuany

zhexuany Nov 25, 2019

Author Member

The second return is the real return. I'll fix it.

This comment has been minimized.

Copy link
@birdstorm

birdstorm Nov 25, 2019

Member

two replies and two returns... lmao

@zhexuany zhexuany force-pushed the zhexuany:disable_set_and_enum_push_down branch from 4a17817 to 2325e8b Nov 25, 2019
@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 25, 2019

`/run-all-tests

Copy link
Collaborator

marsishandsome left a comment

LGTM

zhexuany added 2 commits Nov 25, 2019
@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 26, 2019

/run-all-tests

Copy link
Member

birdstorm left a comment

LGTM

@zhexuany zhexuany merged commit 0b82d28 into pingcap:master Nov 26, 2019
3 checks passed
3 checks passed
idc-jenkins-ci-tispark/build Jenkins job succeeded.
Details
idc-jenkins-ci-tispark/integration-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@zhexuany zhexuany deleted the zhexuany:disable_set_and_enum_push_down branch Nov 26, 2019
zhexuany added a commit to zhexuany/tispark that referenced this pull request Dec 5, 2019
zhexuany added a commit to zhexuany/tispark that referenced this pull request Dec 5, 2019
zhexuany added a commit to zhexuany/tispark that referenced this pull request Dec 5, 2019
zhexuany added a commit to zhexuany/tispark that referenced this pull request Dec 5, 2019
zhexuany added a commit to zhexuany/tispark that referenced this pull request Dec 5, 2019
zhexuany added a commit that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.