Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug of encodeKey of DecimalType #1254

Merged
merged 9 commits into from Nov 28, 2019

Conversation

@zhexuany
Copy link
Member

zhexuany commented Nov 27, 2019

What problem does this PR solve?

When we encodeKey of DecimalType, we did not consider type's precision and fraction.

@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 27, 2019

/run-all-tests tidb=v3.0.5

@zhexuany zhexuany changed the title fix a buf of encodeKey of DecimalType fix a bug of encodeKey of DecimalType Nov 27, 2019
@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 27, 2019

/run-all-tests tidb=v3.0.5

zhexuany added 2 commits Nov 27, 2019
Copy link
Collaborator

ilovesoup left a comment

LGTM

zhexuany added 2 commits Nov 27, 2019
@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 27, 2019

/run-all-tests tidb=v3.0.5

@marsishandsome

This comment has been minimized.

Copy link
Collaborator

marsishandsome commented Nov 28, 2019

need to cherry-pick to release branch?

@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 28, 2019

/run-all-tests tidb=v3.0.5

@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 28, 2019

@marsishandsome This PR is merged to another branch rather than master. We can cherry pick it another branch later.

zhexuany added 2 commits Nov 28, 2019
@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Nov 28, 2019

/run-all-tests tidb=v3.0.5

@zhexuany zhexuany merged commit 93d94ff into pingcap:push_decimal Nov 28, 2019
1 of 2 checks passed
1 of 2 checks passed
idc-jenkins-ci-tispark/build Jenkins job is running.
Details
license/cla Contributor License Agreement is signed.
Details
@zhexuany zhexuany deleted the zhexuany:fix_decimal_encode_key branch Nov 28, 2019
zhexuany added a commit that referenced this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.