New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry for getRegion requests when regionId returns 0 #542

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@birdstorm
Copy link
Member

birdstorm commented Jan 2, 2019

When retrieved region id in getRegionResponse is zero, it indicates that region peer is not elected yet, so we should wait for a short period of time and retry rather than initializing TiRegion with this zero-id.

@birdstorm birdstorm requested review from ilovesoup and zhexuany Jan 2, 2019

@zhexuany
Copy link
Member

zhexuany left a comment

LGTM

@zhexuany

This comment has been minimized.

Copy link
Member

zhexuany commented Jan 3, 2019

/run-all-tests

@zhexuany zhexuany merged commit ca04bd1 into master Jan 3, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tispark/build Jenkins job succeeded.
Details
jenkins-ci-tispark/integration-common-test Jenkins job succeeded.
Details

@zhexuany zhexuany deleted the add_getRegion_retry branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment