New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ti version usable without selecting database #545

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@birdstorm
Copy link
Member

birdstorm commented Jan 4, 2019

Fix #543

@birdstorm birdstorm requested review from ilovesoup and zhexuany Jan 4, 2019

@birdstorm

This comment has been minimized.

Copy link
Member

birdstorm commented Jan 4, 2019

/run-all-tests

@ilovesoup
Copy link
Collaborator

ilovesoup left a comment

Why do we need this change? Does it involve reflection?

@birdstorm

This comment has been minimized.

Copy link
Member

birdstorm commented Jan 5, 2019

@ilovesoup We do, because TiResolutionRule is implied when extension is set. changing it from lazy will make TiContext be initialized in injection state, before we use use $database statement.

@zhexuany zhexuany merged commit 0e214c4 into master Jan 5, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tispark/build Jenkins job succeeded.
Details
jenkins-ci-tispark/integration-common-test Jenkins job succeeded.
Details

@zhexuany zhexuany deleted the fix_ti_version branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment