Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Json code #633

Merged
merged 7 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@birdstorm
Copy link
Member

birdstorm commented Apr 8, 2019

@zhexuany PTAL

@birdstorm birdstorm requested a review from zhexuany Apr 8, 2019

@birdstorm

This comment has been minimized.

Copy link
Member Author

birdstorm commented Apr 8, 2019

/run-all-tests

1 similar comment
@birdstorm

This comment has been minimized.

Copy link
Member Author

birdstorm commented Apr 8, 2019

/run-all-tests

birdstorm added some commits Apr 8, 2019

@birdstorm

This comment has been minimized.

Copy link
Member Author

birdstorm commented Apr 8, 2019

/run-all-tests

@zhexuany zhexuany requested review from zhexuany and marsishandsome Apr 9, 2019

@zhexuany

This comment has been minimized.

Copy link
Member

zhexuany commented Apr 9, 2019

/cc @marsishandsome PTAL

@marsishandsome
Copy link
Collaborator

marsishandsome left a comment

LGTM

@zhexuany
Copy link
Member

zhexuany left a comment

LGTM

@zhexuany zhexuany merged commit 847525f into master Apr 9, 2019

1 check passed

idc-jenkins-ci-tispark/build Jenkins job succeeded.
Details

@zhexuany zhexuany deleted the cleanup-json branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.