Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't import spark's dep #634

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@zhexuany
Copy link
Member

zhexuany commented Apr 8, 2019

Soon or later we may separate tikv-java-client out, so we're better not to import any spark's dep.

@zhexuany zhexuany requested a review from birdstorm Apr 8, 2019

@birdstorm
Copy link
Member

birdstorm left a comment

some problems still exists, but we can fix them in another pr.

@birdstorm
Copy link
Member

birdstorm left a comment

will be merged after tests all passed.

@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Apr 8, 2019

/run-all-tests

@pingcap pingcap deleted a comment from birdstorm Apr 8, 2019

@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Apr 8, 2019

local ci passed. idc's ci has some problems.

@zhexuany zhexuany merged commit 757c5f9 into pingcap:master Apr 8, 2019

1 of 2 checks passed

idc-jenkins-ci-tispark/integration-test Jenkins job failed
Details
idc-jenkins-ci-tispark/build Jenkins job succeeded.
Details

@zhexuany zhexuany deleted the zhexuany:donnot_import_spark_dep branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.