Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index push down #697

Merged
merged 8 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@birdstorm
Copy link
Member

commented May 6, 2019

Allow indexScan to push down filters, aggregates, limits, etc.
Fix covering index pushing down
Fix incorrect statics result due to TypedKey.next and timestamp
Should also close #408

@birdstorm birdstorm added the WIP label May 6, 2019

@birdstorm birdstorm requested a review from zhexuany May 6, 2019

@birdstorm birdstorm removed the WIP label May 7, 2019

@birdstorm birdstorm changed the title [WIP] Fix index push down Fix index push down May 7, 2019

@birdstorm

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

/run-all-tests

@@ -69,35 +69,45 @@ object StatisticsHelper {
neededColIds: mutable.ArrayBuffer[Long],
histTable: TiTableInfo): StatisticsDTO = {
if (row.fieldCount() < 6) return null
assert(row.getLong(0) == table.getId, s"table id not match ${row.getLong(0)}!=${table.getId}")

This comment has been minimized.

Copy link
@birdstorm

birdstorm May 7, 2019

Author Member

I will remove this line of assert after all tests are passed.

@birdstorm

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

/run-all-tests

@birdstorm

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

/run-all-tests

@birdstorm

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

/run-all-tests

import com.google.common.collect.Range;
import com.pingcap.tikv.predicates.IndexRange;

abstract class KeyRangeBuilder {

This comment has been minimized.

Copy link
@zhexuany

zhexuany May 8, 2019

Member

it is better to include some comments.

@zhexuany
Copy link
Member

left a comment

LGTM

@birdstorm

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

/run-all-tests

@birdstorm

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

Test failed is ignored and included by #701 .
This PR is ready to merge.

@birdstorm

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

/run-all-tests

@zhexuany zhexuany merged commit 9bb9373 into master May 8, 2019

2 of 3 checks passed

idc-jenkins-ci-tispark/integration-test Jenkins job is running.
Details
idc-jenkins-ci-tispark/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zhexuany zhexuany deleted the fix-index-push-down branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.