Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto increment #793

Merged
merged 6 commits into from Jun 9, 2019

Conversation

Projects
None yet
3 participants
@zhexuany
Copy link
Member

commented Jun 5, 2019

In this PR, changes are made to support auto increment column case.

@zhexuany zhexuany requested review from marsishandsome and birdstorm and removed request for marsishandsome Jun 5, 2019

@marsishandsome
Copy link
Collaborator

left a comment

others LGTM

@zhexuany zhexuany force-pushed the zhexuany:support_auto_increment_id branch from bc7bcef to 71e203a Jun 6, 2019

@marsishandsome
Copy link
Collaborator

left a comment

LGTM

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

/run-all-tests

@zhexuany zhexuany force-pushed the zhexuany:support_auto_increment_id branch from 474361b to b5855a9 Jun 6, 2019

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@zhexuany zhexuany force-pushed the zhexuany:support_auto_increment_id branch from a8a38ff to f085ef4 Jun 6, 2019

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

/run-all-tests

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

/run-all-tests

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

merging since test was already passed.

@zhexuany zhexuany merged commit b4acb3f into pingcap:master Jun 9, 2019

2 of 3 checks passed

idc-jenkins-ci-tispark/build Jenkins job is running.
Details
idc-jenkins-ci-tispark/integration-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zhexuany zhexuany deleted the zhexuany:support_auto_increment_id branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.