Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix count error, if advanceNextResponse is empty, we should read next region #878

Merged
merged 5 commits into from Jul 1, 2019

Conversation

Projects
None yet
3 participants
@marsishandsome
Copy link
Collaborator

commented Jul 1, 2019

closing #877

In DATIterator, if advanceNextResponse is empty, we should read next region instead of just return false.

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

/run-all-tests

@marsishandsome marsishandsome force-pushed the marsishandsome:bugfix/count-error branch from 88805ac to 29457da Jul 1, 2019

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

/run-all-tests

@birdstorm

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Good job! I will try to reproduce it.

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

/run-all-tests

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@marsishandsome marsishandsome requested a review from birdstorm Jul 1, 2019

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@zhexuany
Copy link
Member

left a comment

LGTM

@birdstorm
Copy link
Member

left a comment

lgtm

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@marsishandsome marsishandsome changed the title fix count error fix count error, if advanceNextResponse is empty, we should read next region Jul 1, 2019

@marsishandsome marsishandsome merged commit 0286008 into pingcap:master Jul 1, 2019

3 checks passed

idc-jenkins-ci-tispark/build Jenkins job succeeded.
Details
idc-jenkins-ci-tispark/integration-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

marsishandsome added a commit to marsishandsome/tispark that referenced this pull request Jul 1, 2019

marsishandsome added a commit that referenced this pull request Jul 1, 2019

marsishandsome added a commit to marsishandsome/tispark that referenced this pull request Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.