Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill zero when encoding binary #888

Merged

Conversation

Projects
None yet
3 participants
@marsishandsome
Copy link
Collaborator

commented Jul 2, 2019

close #774

fill zero when encoding binary type

if (data.size < binaryColumn.size) {
    fill with zero at the end
}

@marsishandsome marsishandsome force-pushed the marsishandsome:hotfix/enocde-binary-fill-zero branch from f8de3db to 7354ffb Jul 2, 2019

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 2, 2019

/run-all-tests tikv=v2.1.9 tidb=v2.1.9 pd=v2.1.9

@marsishandsome marsishandsome requested review from zhexuany and birdstorm Jul 2, 2019

@birdstorm
Copy link
Member

left a comment

LGTM

@zhexuany
Copy link
Member

left a comment

LGTM

@zhexuany zhexuany merged commit 992c0cc into pingcap:master Jul 2, 2019

3 checks passed

idc-jenkins-ci-tispark/build Jenkins job succeeded.
Details
idc-jenkins-ci-tispark/integration-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.