Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delay clean table lock #905

Merged

Conversation

Projects
None yet
3 participants
@marsishandsome
Copy link
Collaborator

commented Jul 5, 2019

close #904

The logic of TiSpark to use the table lock is:

  1. lock table
  2. prewrite data.
  3. check whether the locked table session is closed.
  4. if the session doesn't close, do commit.
  5. if the session was closed by unexpected, do a rollback.

The problem is, What if the session was closed by unexpected between step 3 and 4, It will cause some problem.

TiSpark need to delayed release table lock before do commit.

@marsishandsome marsishandsome requested review from zhexuany and birdstorm and removed request for zhexuany Jul 5, 2019

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2019

/run-all-tests

@marsishandsome marsishandsome force-pushed the marsishandsome:feature/delay-clean-table-lock branch from 588f407 to 27d5c2a Jul 5, 2019

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2019

/run-all-tests

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2019

/run-all-tests

@marsishandsome

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2019

@birdstorm PTAL again

@birdstorm
Copy link
Member

left a comment

LGTM

@marsishandsome marsishandsome merged commit 5ce8bf7 into pingcap:master Jul 5, 2019

3 checks passed

idc-jenkins-ci-tispark/build Jenkins job succeeded.
Details
idc-jenkins-ci-tispark/integration-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.