Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix index scan bug #995

Merged
merged 4 commits into from Aug 8, 2019

Conversation

@zhexuany
Copy link
Member

commented Aug 7, 2019

What problem does this PR solve?

When we do index scan, we should not add required index data type.

What is changed and how it works?

Remove related code in double read case.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

@zhexuany zhexuany requested a review from birdstorm Aug 7, 2019

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@marsishandsome

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

cherry pick to release-2.1?

@marsishandsome
Copy link
Collaborator

left a comment

LGTM

@birdstorm
Copy link
Member

left a comment

LGTM

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

/run-all-tests

1 similar comment
@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

/run-all-tests

@zhexuany zhexuany force-pushed the zhexuany:fix_index_scan_bug branch from 0116304 to 2428858 Aug 8, 2019

@zhexuany

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

/run-all-tests

@zhexuany zhexuany merged commit 911e890 into pingcap:master Aug 8, 2019

3 checks passed

idc-jenkins-ci-tispark/build Jenkins job succeeded.
Details
idc-jenkins-ci-tispark/integration-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zhexuany zhexuany deleted the zhexuany:fix_index_scan_bug branch Aug 8, 2019

marsishandsome added a commit to marsishandsome/tispark that referenced this pull request Aug 15, 2019

fix index scan bug (pingcap#995)
(cherry picked from commit 911e890)

marsishandsome added a commit that referenced this pull request Aug 15, 2019

fix index scan bug (#995) (#1024)
(cherry picked from commit 911e890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.