adding key-validator option to make-column-family #32

Merged
merged 5 commits into from Aug 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

ryfow commented Jul 26, 2012

Just wrapping BasicColumnFamilyDefinition.setKeyValidationClass() in make-column-family.

I'd be happy to write a test for it if someone lets me know how to run the tests without getting the following exception: java.lang.ClassNotFoundException: org.apache.cassandra.service.EmbeddedCassandraService

Owner

pingles commented Aug 8, 2012

Hi Ryan,

Thanks for your patch!

I've just pushed a change so that the project builds with Leiningen 2- could you check you're using lein 2 and try running the tests again? Let me know if you still get a ClassNotFoundException.

Thanks,
Paul

Contributor

ryfow commented Aug 8, 2012

The tests run now, thanks. If there's a compilation problem, it hangs for some reason. I can live with that.

I updated tests changed the key name to :k-validator to match some of your other names. Do you prefer the commits to be squashed?

Owner

pingles commented Aug 8, 2012

Nope that's fine- I'll merge it in. Thanks again for your contribution!

pingles added a commit that referenced this pull request Aug 8, 2012

Merge pull request #32 from rwfowler/add-key-validator
adding key-validator option to make-column-family

@pingles pingles merged commit 471bca2 into pingles:master Aug 8, 2012

Owner

pingles commented Aug 8, 2012

I've merged these in and pushed a 0.2.2 release to Clojars.

Contributor

ryfow commented Aug 8, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment