Fix issue #1: Not all packages are shown #2

Merged
merged 2 commits into from Apr 28, 2012

Conversation

Projects
None yet
2 participants
Contributor

markvl commented Apr 24, 2012

Because existing_package is an sqlalchemy.orm.query.Query object it
evaluates to True. So even if there were no results, the code would
not create a new Package. (And, since the first result of the Query
would be None, the packages_list would have None appended instead of a
Package.)

Mark van Lent added some commits Apr 24, 2012

Mark van Lent Fix issue #1: Not all packages are shown.
Because existing_package is an sqlalchemy.orm.query.Query object it
evaluates to True. So even if there were no results, the code would
not create a new Package. (And, since the first result of the Query
would be None, the packages_list would have None appended instead of a
Package.)
6328e19
Mark van Lent Take into account that existing_package can be None. 313b389

pingviini merged commit df20908 into pingviini:master Apr 28, 2012

Owner

pingviini commented Apr 28, 2012

Merged both of your pull-requests. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment