From f3bbc71ae59a1031755a464bd90e4761e562ce73 Mon Sep 17 00:00:00 2001 From: Andrey Kan Date: Tue, 19 Mar 2024 14:59:26 -0400 Subject: [PATCH 1/3] Process all arguments debug.js style --- debug.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/debug.js b/debug.js index 3f186f4..ff4c24f 100644 --- a/debug.js +++ b/debug.js @@ -1,5 +1,7 @@ 'use strict' +var util = require('util'); + module.exports = debug function debug (namespace) { @@ -16,7 +18,10 @@ function debug (namespace) { function disabled () {} disabled.enabled = false function enabled () { - return log.apply(logger, arguments) + //return log.apply(logger, arguments) + + let message = util.format.apply(util, arguments) // this is how debug.js formats argeuments + return log.apply(logger, [message]) } enabled.enabled = true From d11aeed6208978696ffe65a8aa1a06e675e4dfee Mon Sep 17 00:00:00 2001 From: tevch Date: Thu, 18 Apr 2024 10:18:55 -0400 Subject: [PATCH 2/3] add test for Process all arguments debug.js style --- test/index.js | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/test/index.js b/test/index.js index 37345bd..a33dce1 100644 --- a/test/index.js +++ b/test/index.js @@ -2,6 +2,8 @@ var execSync = require('child_process').execSync var tap = require('tap') var through = require('through2') +const pinoDebug = require("../index"); +const debug = require("debug"); var test = tap.test const debugModules = [ @@ -342,3 +344,20 @@ test('does not invalidate strict mode', (t) => { t.is(require('./fixtures/strict-mode'), true) t.end() }) + +test('Process all arguments debug.js style', (t) => { + var testOptions={"option1":"value1"}; + process.env.DEBUG = 'ns1' + var pinoDebug = require('../') + var stream = through((line, _, cb) => { + var obj = JSON.parse(line) + var expectedMsg = "test { option1: 'value1' }"; + t.is(obj.msg, expectedMsg) + t.is(obj.ns, 'ns1') + t.end() + }) + pinoDebug(require('pino')({level: 'debug'}, stream)) + var debug = require('debug') + + debug('ns1')('test', testOptions) +}) From eb827343c1646aebf46441cce26407483e3d9c21 Mon Sep 17 00:00:00 2001 From: tevch Date: Mon, 22 Apr 2024 09:37:15 -0400 Subject: [PATCH 3/3] removed comment line --- debug.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/debug.js b/debug.js index ff4c24f..be82eba 100644 --- a/debug.js +++ b/debug.js @@ -18,8 +18,6 @@ function debug (namespace) { function disabled () {} disabled.enabled = false function enabled () { - //return log.apply(logger, arguments) - let message = util.format.apply(util, arguments) // this is how debug.js formats argeuments return log.apply(logger, [message]) }