From 6f30140347fafb26efb4f25332e8b31b0f626354 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Tue, 3 Oct 2023 17:37:30 +0200 Subject: [PATCH] Disable FinalizationRegistry if NODE_V8_COVERAGE is set (#464) * Disable FinalizationRegistry if NODE_V8_COVERAGE is set Signed-off-by: Matteo Collina * fixup Signed-off-by: Matteo Collina --------- Signed-off-by: Matteo Collina --- lib/utils/build-safe-sonic-boom.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/utils/build-safe-sonic-boom.js b/lib/utils/build-safe-sonic-boom.js index 1ed1f6e7..fadfe290 100644 --- a/lib/utils/build-safe-sonic-boom.js +++ b/lib/utils/build-safe-sonic-boom.js @@ -17,6 +17,11 @@ function buildSafeSonicBoom (opts) { const stream = new SonicBoom(opts) stream.on('error', filterBrokenPipe) // if we are sync: false, we must flush on exit + // NODE_V8_COVERAGE must breaks everything + // https://github.com/nodejs/node/issues/49344 + if (!process.env.NODE_V8_COVERAGE && !opts.sync && isMainThread) { + setupOnExit(stream) + } if (!opts.sync && isMainThread) { setupOnExit(stream) }