Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for numbers #70

Merged
merged 3 commits into from Jun 18, 2019

Conversation

@ovhemert
Copy link
Contributor

ovhemert commented Jun 18, 2019

Checks for number input and prevents crashing as reported in issue #69

Example: node -e 'console.log(2)' | node ./bin.js

Copy link
Member

davidmarkclements left a comment

LGTM!

Copy link
Member

davidmarkclements left a comment

oh wait, sorry could you please add a test for this

Copy link
Contributor

jsumners left a comment

LGTM

Copy link
Member

davidmarkclements left a comment

👍

Copy link
Member

mcollina left a comment

LGTM

@mcollina mcollina merged commit 74a1894 into pinojs:master Jun 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ovhemert ovhemert deleted the ovhemert:number-input-check branch Jun 18, 2019
@Tiim Tiim referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.