Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through non-object valid JSON, fixes #72 #81

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@marinintim
Copy link
Contributor

marinintim commented Oct 6, 2019

  • Add test for passing through double-quoted string from JSON.stringify(new Date())
  • Check for parsed value being JS object, otherwise just fallthrough as on parse error
* Add test for passing through double-quoted string from JSON.stringify(new Date())
* Check for parsed value being JS object, otherwise just fallthrough as on parse error
Copy link
Member

mcollina left a comment

LGTM

Copy link
Contributor

jsumners left a comment

LGTM

@mcollina mcollina merged commit 71935ea into pinojs:master Oct 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@marinintim marinintim deleted the marinintim:feat/dont-crash-on-date branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.