From 53b7597a5503cf823f5b0897837ab1f4862cd84c Mon Sep 17 00:00:00 2001 From: Igor Savin Date: Sat, 4 Sep 2021 12:53:21 +0300 Subject: [PATCH] Add overload to handle unknown returned by TS-4.4 for errors be default --- package.json | 4 ++-- pino.d.ts | 1 + test/types/pino.test-d.ts | 6 ++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 32161e79b..56238eb44 100644 --- a/package.json +++ b/package.json @@ -64,7 +64,7 @@ }, "homepage": "http://getpino.io", "devDependencies": { - "@types/node": "^16.7.2", + "@types/node": "^16.7.10", "airtap": "4.0.3", "benchmark": "^2.1.4", "bole": "^4.0.0", @@ -94,7 +94,7 @@ "through2": "^4.0.0", "ts-node": "^10.2.1", "tsd": "^0.17.0", - "typescript": "^4.4.2", + "typescript": "4.4.2", "winston": "^3.3.3" }, "dependencies": { diff --git a/pino.d.ts b/pino.d.ts index a29952460..12a1a10cd 100644 --- a/pino.d.ts +++ b/pino.d.ts @@ -886,6 +886,7 @@ declare namespace P { interface LogFn { /* tslint:disable:no-unnecessary-generics */ (obj: T, msg?: string, ...args: any[]): void; + (obj: unknown, msg?: string, ...args: any[]): void; (msg: string, ...args: any[]): void; } diff --git a/test/types/pino.test-d.ts b/test/types/pino.test-d.ts index b3c934bca..630c60b68 100644 --- a/test/types/pino.test-d.ts +++ b/test/types/pino.test-d.ts @@ -253,6 +253,12 @@ pino({ name: "my-logger" }, destinationViaStream); pino(destinationViaOptionsObject); pino({ name: "my-logger" }, destinationViaOptionsObject); +try { + throw new Error('Some error') +} catch (err) { + log.error(err) +} + interface StrictShape { activity: string; err?: unknown;