Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that watchFileCreated fails are timeouts #1219

Merged
merged 1 commit into from Nov 15, 2021

Conversation

@voxpelli
Copy link
Contributor

@voxpelli voxpelli commented Nov 15, 2021

Relates to #1215, where it looks like the error is that a file isn't created, but it can just as well (and more likely) be that the file watch times out.

This change avoids such confusion going forward.

Copy link
Member

@mcollina mcollina left a comment

lgtm

@voxpelli voxpelli mentioned this pull request Nov 15, 2021
@mcollina mcollina merged commit 8fde791 into pinojs:master Nov 15, 2021
12 checks passed
@voxpelli voxpelli deleted the clarify-file-creation-watch-error branch Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants