Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward all unknown options passed to pino/file transport to destination #1234

Merged

Conversation

@mojavelinux
Copy link
Contributor

@mojavelinux mojavelinux commented Nov 20, 2021

As discussed in #1229.

We delete the destination property just to avoid any confusion since that's not a properly that pino.destination / SonicBoom recognizes.

Copy link
Member

@mcollina mcollina left a comment

lgtm

@mcollina mcollina merged commit 0433f54 into pinojs:master Nov 20, 2021
15 checks passed
@mojavelinux mojavelinux deleted the pass-all-opts-to-file-destination branch Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants