Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determining whether to insert a header according to the broker in Kafka Plugin #7365

Closed
koo-taejin opened this issue Oct 27, 2020 · 0 comments
Closed

Determining whether to insert a header according to the broker in Kafka Plugin #7365

koo-taejin opened this issue Oct 27, 2020 · 0 comments
Assignees
@koo-taejin
Labels
enhancement module:plugin
Milestone
2.1.1

Comments

@koo-taejin
Copy link
Member

description

Kafka clients can communicate with broker regardless of the broker version.
If Kafka clients connect to broker that not supports header, Kafka client will occur V1 magic exception

This will be solved by determining whether to insert a header according to whether a broker header is supported or not.

Expected behavior by situation

ProducerA --- Broker (supporting Header)
ProducerB --- Broker (not supporting Header)
ProducerC --- 3 Broker (2 Broker supporing Header, 1 Broker not supporting Header)

ProducerA will add Pinpoint Header. (Remote trace : O)
ProducerB will not add Pinpoint Header. (Remote trace : X)
ProducerC will not add Pinpoint Header. (Remote trace : X)
@koo-taejin koo-taejin added this to the 2.1.1 milestone Oct 27, 2020
@koo-taejin koo-taejin self-assigned this Oct 27, 2020
@koo-taejin koo-taejin changed the title Fixes Kafka client occurs exception when it communicate with v0.11- Broker Determining whether to insert a header according to the broker in Kafka Plugin Oct 27, 2020
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Oct 27, 2020
@koo-taejin
[pinpoint-apm#7365] Determining whether to insert a header according …
9452d9c 
…to the broker in Kafka Plugin
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Oct 27, 2020
@koo-taejin
[pinpoint-apm#7365] Determining whether to insert a header according …
e95679e 
…to the broker in Kafka Plugin
koo-taejin added a commit that referenced this issue Oct 27, 2020
@koo-taejin
[#7365] Determining whether to insert a header according to the broke…
3d63a8e 
…r in Kafka Plugin
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Nov 23, 2020
@koo-taejin
[pinpoint-apm#7365] Fix getting localAddress when SocketChannel state…
9c82af5 
… is connecting
koo-taejin added a commit that referenced this issue Nov 24, 2020
@koo-taejin
[#7365] Fix getting localAddress when SocketChannel state is connecting
f793813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koo-taejin koo-taejin

Labels
enhancement module:plugin
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
1 participant
@koo-taejin