Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Fix netty IT #9279

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

jaehong-kim
Copy link
Contributor

Stacktrace

com.navercorp.pinpoint.test.plugin.PinpointPluginTestException: java.lang.AssertionError: SpanEvent.serviceType expected:[9150] but was:[9151] expected:<SpanEvent(serviceType: 9150, apiId: 18, exception: null, rpc: ExpectedTraceField{expectedType=ALWAYS_TRUE, expected='null'}, endPoint: ExpectedTraceField{expectedType=ALWAYS_TRUE, expected='null'}, remoteAddr: ExpectedTraceField{expectedType=ALWAYS_TRUE, expected='null'}, destinationId: ExpectedTraceField{expectedType=ALWAYS_TRUE, expected='null'}, annotations: [], localAsyncId: null)> but was:<SpanEvent(serviceType: 9151, apiId: -20, exception: null, rpc: null, endPoint: null, destinationId: null, annotations: [], localAsyncId: 26, nextAsyncId: null)>

@jaehong-kim jaehong-kim added this to the 2.5.0 milestone Oct 19, 2022
@jaehong-kim jaehong-kim self-assigned this Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #9279 (309cb8a) into master (781da9a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9279      +/-   ##
============================================
- Coverage     39.59%   39.58%   -0.01%     
+ Complexity    11835    11830       -5     
============================================
  Files          3409     3409              
  Lines         91565    91565              
  Branches      10160    10160              
============================================
- Hits          36255    36248       -7     
- Misses        52210    52214       +4     
- Partials       3100     3103       +3     
Impacted Files Coverage Δ
...p/pinpoint/rpc/client/WriteFailFutureListener.java 56.25% <0.00%> (-25.00%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 68.51% <0.00%> (-7.41%) ⬇️
...tor/metric/datasource/DefaultDataSourceMetric.java 85.18% <0.00%> (-3.71%) ⬇️
...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java 51.66% <0.00%> (-1.67%) ⬇️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 78.07% <0.00%> (-1.61%) ⬇️
.../pinpoint/metric/common/pinot/PinotDataSource.java 50.00% <0.00%> (+4.54%) ⬆️
...p/pinpoint/rpc/stream/StreamChannelRepository.java 78.94% <0.00%> (+21.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jaehong-kim jaehong-kim merged commit 0576c69 into pinpoint-apm:master Oct 19, 2022
@jaehong-kim jaehong-kim deleted the fix-netty-it branch October 19, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant