New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static declarations #56

Merged
merged 2 commits into from Jan 1, 2016

Conversation

Projects
None yet
2 participants
@chuganzy
Contributor

chuganzy commented Dec 29, 2015

As titled.

@jparise

This comment has been minimized.

Show comment
Hide comment
@jparise

jparise Jan 1, 2016

Member

Thanks! I doubt anyone was relying on these symbols being link-able, especially without any formal extern declarations in the headers.

Member

jparise commented Jan 1, 2016

Thanks! I doubt anyone was relying on these symbols being link-able, especially without any formal extern declarations in the headers.

jparise added a commit that referenced this pull request Jan 1, 2016

@jparise jparise merged commit ed17f00 into pinterest:master Jan 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chuganzy

This comment has been minimized.

Show comment
Hide comment
@chuganzy

chuganzy Jan 1, 2016

Contributor

🍻

Contributor

chuganzy commented Jan 1, 2016

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment