Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static declarations #56

Merged
merged 2 commits into from Jan 1, 2016
Merged

Fix static declarations #56

merged 2 commits into from Jan 1, 2016

Conversation

@chuganzy
Copy link
Contributor

chuganzy commented Dec 29, 2015

As titled.

Takeru Chuganji added 2 commits Dec 29, 2015
Takeru Chuganji
@jparise
Copy link
Member

jparise commented Jan 1, 2016

Thanks! I doubt anyone was relying on these symbols being link-able, especially without any formal extern declarations in the headers.

jparise added a commit that referenced this pull request Jan 1, 2016
Fix static declarations
@jparise jparise merged commit ed17f00 into pinterest:master Jan 1, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chuganzy
Copy link
Contributor Author

chuganzy commented Jan 1, 2016

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.