Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'default required' fields to be nil #137

Merged
merged 2 commits into from Jan 3, 2017

Conversation

pguillory
Copy link
Collaborator

We discovered that other Thrift implementations we use internally do not
serialize unset 'default required' fields. This change brings our
implementation's behavior in line with the others.

We discovered that other Thrift implementations we use internally do not
serialize unset 'default required' fields. This change brings our
implementation's behavior in line with the others.
@pguillory
Copy link
Collaborator Author

Fixes #136.

@dantswain dantswain requested a review from scohen January 3, 2017 18:34
Copy link
Collaborator

@dantswain dantswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include tests that show whether or not the value is being written? It would help clarify the behavior if nothing else.

@scohen
Copy link
Collaborator

scohen commented Jan 3, 2017

to @dantswain's point, we should probably change some of the old tests to not specify optional and make use of default requiredness.

@pguillory pguillory merged commit c51fb22 into pinterest:thrift_tng Jan 3, 2017
@pguillory pguillory deleted the default_not_required branch January 3, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants