Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap long lines in generated output #175

Merged
merged 1 commit into from Jan 11, 2017

Conversation

pguillory
Copy link
Collaborator

Generated module names can be quite long, so this pattern produces very long
lines because Macro.to_string does not wrap pipe operators to the next line.

serialized_var = %Big.Generated.Module{} |> Big.Generated.Module.serialize()

This change just replaces it with a slightly more readable:

var = %Big.Generated.Module{}
Big.GeneratedModule.serialize(var)

Generated module names can be quite long, so this pattern produces very long
lines because Macro.to_string does not wrap pipe operators to the next line.

  serialized_var = %Big.Generated.Module{} |> Big.Generated.Module.serialize()

This change just replaces it with a slightly more readable:

  var = %Big.Generated.Module{}
  Big.GeneratedModule.serialize(var)
@pguillory pguillory merged commit c2a1f51 into pinterest:thrift_tng Jan 11, 2017
@pguillory pguillory deleted the wrap_pipes branch January 11, 2017 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants