From 4ab68e0d9b8cc0bd04dc9c705a1d8e6e451700e5 Mon Sep 17 00:00:00 2001 From: Erica Norris Date: Fri, 18 Dec 2020 12:23:23 -0800 Subject: [PATCH] removed target so behavior matches current behavior --- packages/gestalt/src/Callout.js | 1 - packages/gestalt/src/Upsell.js | 1 - .../src/__snapshots__/Callout.test.js.snap | 16 +++++++-------- .../src/__snapshots__/Upsell.test.js.snap | 20 +++++++++---------- 4 files changed, 18 insertions(+), 20 deletions(-) diff --git a/packages/gestalt/src/Callout.js b/packages/gestalt/src/Callout.js index 4585a7e797..2e894218bd 100644 --- a/packages/gestalt/src/Callout.js +++ b/packages/gestalt/src/Callout.js @@ -92,7 +92,6 @@ const CalloutAction = ({ onClick={onClick} role="link" size="lg" - target="blank" text={label} /> ) : ( diff --git a/packages/gestalt/src/Upsell.js b/packages/gestalt/src/Upsell.js index 913747b4d0..988084edb8 100644 --- a/packages/gestalt/src/Upsell.js +++ b/packages/gestalt/src/Upsell.js @@ -76,7 +76,6 @@ const UpsellAction = ({ onClick={onClick} role="link" size="lg" - target="blank" text={label} /> ) : ( diff --git a/packages/gestalt/src/__snapshots__/Callout.test.js.snap b/packages/gestalt/src/__snapshots__/Callout.test.js.snap index b03643cf7b..685f2bae80 100644 --- a/packages/gestalt/src/__snapshots__/Callout.test.js.snap +++ b/packages/gestalt/src/__snapshots__/Callout.test.js.snap @@ -276,9 +276,9 @@ exports[` message + title + primaryAction + dismissButton 1`] = ` onTouchEnd={[Function]} onTouchMove={[Function]} onTouchStart={[Function]} - rel="noopener noreferrer" + rel="" tabIndex={0} - target="_blank" + target={null} >
message + title + primaryAction + secondaryAction 1`] = ` onTouchEnd={[Function]} onTouchMove={[Function]} onTouchStart={[Function]} - rel="noopener noreferrer" + rel="" tabIndex={0} - target="_blank" + target={null} >
message + title + primaryAction + secondaryAction 1`] = ` onTouchEnd={[Function]} onTouchMove={[Function]} onTouchStart={[Function]} - rel="noopener noreferrer" + rel="" tabIndex={0} - target="_blank" + target={null} >
message + title + primaryAction with href 1`] = ` onTouchEnd={[Function]} onTouchMove={[Function]} onTouchStart={[Function]} - rel="noopener noreferrer" + rel="" tabIndex={0} - target="_blank" + target={null} >
message + title + primaryAction + dismissButton + image 1`] onTouchEnd={[Function]} onTouchMove={[Function]} onTouchStart={[Function]} - rel="noopener noreferrer" + rel="" tabIndex={0} - target="_blank" + target={null} >
message + title + primaryAction + dismissButton 1`] = ` onTouchEnd={[Function]} onTouchMove={[Function]} onTouchStart={[Function]} - rel="noopener noreferrer" + rel="" tabIndex={0} - target="_blank" + target={null} >
message + title + primaryAction + secondaryAction 1`] = ` onTouchEnd={[Function]} onTouchMove={[Function]} onTouchStart={[Function]} - rel="noopener noreferrer" + rel="" tabIndex={0} - target="_blank" + target={null} >
message + title + primaryAction + secondaryAction 1`] = ` onTouchEnd={[Function]} onTouchMove={[Function]} onTouchStart={[Function]} - rel="noopener noreferrer" + rel="" tabIndex={0} - target="_blank" + target={null} >
message + title + primaryAction with href 1`] = ` onTouchEnd={[Function]} onTouchMove={[Function]} onTouchStart={[Function]} - rel="noopener noreferrer" + rel="" tabIndex={0} - target="_blank" + target={null} >