Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callout/Upsell: update primary/secondaryLink to be primary/secondaryAction + Codemod #1314

Merged
merged 5 commits into from Dec 18, 2020

Conversation

norrise120
Copy link
Contributor

@norrise120 norrise120 commented Dec 17, 2020

The purpose of this PR is to update Callout so that primary/secondaryLink can be used as buttons in addition to links. This makes the href prop in primary/secondaryLinks to be optional. If supplied, the button will have a role="link" and role="button" if not. The prop names have also been updated from primary/secondaryLinks to primary/secondaryActions to be more indicative of the new functionality.

Test Plan

Tests and docs have been updated!

Codemod has been added for the breaking changes!

@norrise120 norrise120 requested a review from a team as a code owner December 17, 2020 19:36
@netlify
Copy link

netlify bot commented Dec 17, 2020

✔️ Deploy preview for gestalt ready!

🔨 Explore the source changes: 4ab68e0

🔍 Inspect the deploy logs: https://app.netlify.com/sites/gestalt/deploys/5fdd0fc50c334800075874f0

😎 Browse the preview: https://deploy-preview-1314--gestalt.netlify.app

@norrise120 norrise120 changed the title Callout: update primary/secondaryLink to be primary/secondaryButton Callout/Upsell: update primary/secondaryLink to be primary/secondaryAction Dec 18, 2020
@AlbertCarreras AlbertCarreras changed the title Callout/Upsell: update primary/secondaryLink to be primary/secondaryAction Callout/Upsell: update primary/secondaryLink to be primary/secondaryAction + Codemod Dec 18, 2020
@AlbertCarreras AlbertCarreras added the major release Major release label Dec 18, 2020
@mergify mergify bot merged commit 664437e into pinterest:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major release Major release
Projects
None yet
3 participants