Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Fix broken master due to prettier error on CHANGELOG.md #1896

Conversation

christianvuerings
Copy link
Contributor

Summary

What changed?

  1. Run prettier on CHANGELOG.md file
  2. Prevent future breakages by scripting the prettier run

Why?

Master broke due to an extra space in the PR title in #1890

Screen Shot 2022-02-01 at 7 02 03 AM

$ prettier --check .
Checking formatting...
[warn] CHANGELOG.md
[warn] Code style issues found in the above file(s). Forgot to run Prettier?
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

https://github.com/pinterest/gestalt/runs/5011272978?check_suite_focus=true

@christianvuerings christianvuerings added the patch release Patch release label Feb 1, 2022
@christianvuerings christianvuerings requested a review from a team as a code owner February 1, 2022 15:21
@netlify
Copy link

netlify bot commented Feb 1, 2022

✔️ Deploy Preview for gestalt ready!

🔨 Explore the source changes: 2038a1e

🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/61f9501702d17e000862ac32

😎 Browse the preview: https://deploy-preview-1896--gestalt.netlify.app

@AlbertCarreras AlbertCarreras merged commit dd84adc into pinterest:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
2 participants