Icon: Add right-to-left locales flip style support and update doc #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianvuerings
changed the title
docs/src/Icon.doc.js
Outdated
| flip on RTL locales like Arabic). Consider whether you want to keep the | ||
| original layout on rtl if you are adding new icons. | ||
| </Text> | ||
| <Box display="flex" direction="row"> |
There was a problem hiding this comment.
@selena-zeng Let's remove this Box since the rtl will be a feature across pages
packages/gestalt/src/Icon.js
Outdated
| @@ -34,6 +34,20 @@ type Props = {| | |||
|
|
|||
| const IconNames = Object.keys(icons); | |||
|
|
|||
| const noFlipOnRtlIconNames = [ | |||
| 'facebook', | |||
There was a problem hiding this comment.
@selena-zeng this is different from the approach we talked about - is this in agreement with PDS, that only these icons should not be flipped and all the other ones should?
| html[dir="rtl"] .rtlSupport { | ||
| /* Flip the icon for right-to-left language locales */ | ||
| transform: rotateY(180deg); | ||
| } |
There was a problem hiding this comment.
@selena-zeng could we add an extra breaking line at the end of this file?
christianvuerings
approved these changes
Jan 22, 2020
|
@selena-zeng Thank you for working with PDS on this - merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Experimental evidence (required for Masonry changes)