Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add live docs to SegementedControl #90

Conversation

@nithindavid
Copy link
Contributor

nithindavid commented Mar 20, 2018

see #5

nithindavid added 2 commits Mar 20, 2018
@christianvuerings

This comment has been minimized.

Copy link
Contributor

christianvuerings commented Mar 20, 2018

Deploy preview for gestalt ready!

Built with commit 7c9016b

https://deploy-preview-90--gestalt.netlify.com

@@ -41,84 +40,69 @@ card(
required: true,
description: 'Index of element in `items` that is selected.',
},
{
name: 'size',

This comment has been minimized.

Copy link
@christianvuerings

christianvuerings Mar 21, 2018

Contributor

@nithindavid Thank you for catching this!

);
}}
defaultCode={`
class ToastExample extends React.Component {

This comment has been minimized.

Copy link
@christianvuerings

christianvuerings Mar 21, 2018

Contributor

@nithindavid Seems like the indentation in the docs looks a bit off because of this.

image

selectedItemIndex={this.state.mediumIndex}
onChange={this.handleMediumChange}
/>
<Box marginBottom={2}>

This comment has been minimized.

Copy link
@christianvuerings

christianvuerings Mar 21, 2018

Contributor

@nithindavid Can we remove the large example?

We're trying to make all of the Example's as simple as possible so it's easies to understand what's going on.

@nithindavid

This comment has been minimized.

Copy link
Contributor Author

nithindavid commented Mar 21, 2018

@christianvuerings Done 👍

@christianvuerings christianvuerings merged commit bd046dd into pinterest:master Mar 21, 2018
13 checks passed
13 checks passed
buildkite/gestalt Build #4115 passed (6 minutes, 22 seconds)
Details
buildkite/gestalt/docker-package Passed (15 seconds)
Details
buildkite/gestalt/eslint Passed (43 seconds)
Details
buildkite/gestalt/flowtype Passed (40 seconds)
Details
buildkite/gestalt/ghost-integration-0 Passed (2 minutes, 41 seconds)
Details
buildkite/gestalt/ghost-integration-1 Passed (2 minutes, 46 seconds)
Details
buildkite/gestalt/ghost-integration-2 Passed (5 minutes, 3 seconds)
Details
buildkite/gestalt/jest-chrome Passed (41 seconds)
Details
buildkite/gestalt/jest-node Passed (39 seconds)
Details
buildkite/gestalt/pipeline Passed (13 seconds)
Details
buildkite/gestalt/stylelint Passed (36 seconds)
Details
buildkite/gestalt/zap-danger Passed (19 seconds)
Details
deploy/netlify Deploy preview ready!
Details
@christianvuerings

This comment has been minimized.

Copy link
Contributor

christianvuerings commented Mar 21, 2018

@nithindavid Looking very clean, thank you!

@chrislloyd

This comment has been minimized.

Copy link
Member

chrislloyd commented Mar 21, 2018

🙌 awesome! Thanks very much @nithindavid!

btraut added a commit to btraut/gestalt that referenced this pull request Apr 15, 2018
* Docs: Add live docs to SegementedControl

* Updates Changelog

* Fix alignment issue and remove example for large size
chrislloyd added a commit to chrislloyd/gestalt that referenced this pull request Dec 22, 2018
* Docs: Add live docs to SegementedControl

* Updates Changelog

* Fix alignment issue and remove example for large size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.