Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to agent to assert state updates are working properly #39

Closed
masterada opened this issue May 7, 2019 · 0 comments · Fixed by #40
Closed

Add tests to agent to assert state updates are working properly #39

masterada opened this issue May 7, 2019 · 0 comments · Fixed by #40
Assignees
@masterada

Comments

@masterada
Copy link
Contributor

It seems like agent.OnConnectionStateChange doesn't fire properly in all cases (at least for closed state). Add tests for this, and fix any issues related to it.
@masterada masterada self-assigned this May 7, 2019
@masterada masterada mentioned this issue May 7, 2019
Merged
Sean-Der added a commit that referenced this issue May 9, 2019
@Sean-Der
Emit Closed via ConnectionStateCallback
0c3f90b 
When Close is called on an agent emit 'Closed'
to the connection state callback

Resolves #39
@Sean-Der Sean-Der mentioned this issue May 9, 2019
Merged
Sean-Der added a commit that referenced this issue May 9, 2019
@Sean-Der
Emit Closed via ConnectionStateCallback
49ec3fd 
When Close is called on an agent emit 'Closed'
to the connection state callback

Resolves #39
Sean-Der added a commit that referenced this issue May 9, 2019
@Sean-Der
Emit Closed via ConnectionStateCallback
05cad45 
When Close is called on an agent emit 'Closed'
to the connection state callback

Resolves #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masterada masterada

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit Closed via ConnectionStateCallback pion/ice
1 participant
@masterada