Stream doesn't check for io.ErrShortBuffer returns from reassemblyQueue.read

[cohosh]

Your environment.

• Version: Release
• Browser: N/A
• Other Information - See https://trac.torproject.org/projects/tor/ticket/28942#comment:14

What did you do?

Used the pion/webrtc library for the the proxy side of our snowflake anti-censorship system that reads from a WebRTC connection to the client. I used keroserene/go-webrtc as the library on the client side and found data being dropped despite the usage of a reliable channel.

What did you expect?

I expected to receive all of the data that I sent

What happened?

Large chunks of data were missing.

More details:

It turns out Stream is not returning io.ErrShortBuffer errors from reassemblyQueue.read. Instead the error is being overwritten and the data is lost. Stream.ReadSCTP should instead return the error.