Moved duplicate operation to function

[stephanrotolante]

Description

Nothing crazy here, I was exploring the code base and thought this would be an easy thing to refactor

Essentially I am moving some of the duplicated actions that Get/Put packet allocations from the Pool into reusable functions :)

Reference issue

Fixes #...

[ashellunts]

LGTM, @stephanrotolante can you check linter failure please?

[codecov]

Codecov Report

Base: 77.50% // Head: 77.51% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (769c710) compared to base (6b1e684).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 769c710 differs from pull request most recent head b1f92db. Consider uploading reports for the commit b1f92db to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2255   +/-   ##
=======================================
  Coverage   77.50%   77.51%           
=======================================
  Files          87       87           
  Lines        9261     9264    +3     
=======================================
+ Hits         7178     7181    +3     
  Misses       1649     1649           
  Partials      434      434           

Flag	Coverage Δ
go	79.28% <100.00%> (+<0.01%)	⬆️
wasm	70.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
track_local_static.go	82.60% <100.00%> (+0.33%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[stephanrotolante]

@ashellunts yes, it looks like a commit lint error

[ashellunts]

Can you fix that please? 😀

[stephanrotolante]

@ashellunts updated!

[stephanrotolante]

ok wth give me a sec

[stephanrotolante]

@ashellunts ok I believe I got it this time. And I validated the commit by running the commit lint script on my local. I didn't know when you commit you can format the message like this git commit -m "This is the subject" -m "This is the body"

[stephanrotolante]

@ashellunts IMO this commit lint should run on the users machine via some pre-commit hook. I think these ci runner take to long for this super simple check

What do you think?

[ashellunts]

Personally I prefer not to have them in pre commit hook. When I do temporary, draft commits I don't want linter to block them.

[ashellunts]

@stephanrotolante Have you used scripts from .github folder to run all checks locally?

[stephanrotolante]

@ashellunts thank u for being patient with me

[stephanrotolante]

@ashellunts I wish these workflow would run without someone having to trigger them

[stephanrotolante]

@stephanrotolante Have you used scripts from .github folder to run all checks locally?

yes, now I am dealing with a golang linter error

[ashellunts]

@ashellunts IMO this commit lint should run on the users machine via some pre-commit hook. I think these ci runner take to long for this super simple check

What do you think?

I have found there is a helper script to install linter checks as pre-commit/pre-push
.github/install-hooks.sh

[ashellunts]

@ashellunts I wish these workflow would run without someone having to trigger them

It only happens for a first PR of a contributor, AFAIK.

[ashellunts]

@ashellunts thank u for being patient with me

No worries at all!

[ashellunts]

@Sean-Der I thought AUTHORS should be updated with CI. But that step (generate authors) was skipped for this PR.

@stephanrotolante you can create PR and add yourself to AUTHORS file.

pionbot updated AUTHORS in another PR.